Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icons for search #450

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add icons for search #450

merged 1 commit into from
Dec 11, 2024
+7 −1

Conversation

timja
Copy link
Member

@timja timja commented Dec 11, 2024 •
edited
Loading

Part of jenkinsci/jenkins#10049 but can be merged interdependently

image

Proposed changelog entries

  • Entry 1: Issue, Human-readable Text
  • ...

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change).
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests

@janfaracik
Copy link
Contributor

For jenkinsci/jenkins#10049

@timja timja marked this pull request as ready for review December 11, 2024 20:36
@timja timja requested a review from a team as a code owner December 11, 2024 20:36
jtnord
jtnord previously approved these changes Dec 11, 2024
View reviewed changes
@jtnord jtnord dismissed their stale review December 11, 2024 21:11

missed IconSpec (ab)use

@jtnord jtnord requested a review from a team December 11, 2024 21:11
@jtnord jtnord merged commit 9a984fd into jenkinsci:master Dec 11, 2024
17 checks passed
@timja timja deleted the folder-icon branch December 11, 2024 21:13
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Dec 12, 2024 •
edited
Loading

@timja and @jtnord I think that this release is causing a stack overflow on my Jenkins controller for both Jenkins 2.479.2 and Jenkins 2.489. Initial configurations that I'm using for my experiments are

I need to do more exploring to narrow the steps to duplicate the issue. Will keep you informed as I learn more.

Stack trace is:

2024-12-12 19:58:39.937+0000 [id=20]    WARNING h.ExpressionFactory2$JexlExpression#evaluate: Caught exception evaluating: it.iconClassName in /. Reason: java.lang.reflect.InvocationTargetException
java.lang.StackOverflowError
        at hudson.ExtensionList.lookup(ExtensionList.java:437)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationUI.for_(RelocationUI.java:113)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationAction.<init>(RelocationAction.java:78)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl.createFor(RelocationAction.java:176)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl.createFor(RelocationAction.java:158)
        at hudson.model.Actionable.createFor(Actionable.java:118)
        at hudson.model.Actionable.getAction(Actionable.java:335)
        at PluginClassLoader for branch-api//jenkins.branch.MetadataActionFolderIcon.getIconClassName(MetadataActionFolderIcon.java:76)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.AbstractFolder.getIconClassName(AbstractFolder.java:311)
        at PluginClassLoader for branch-api//jenkins.branch.MetadataActionFolderIcon.getIconClassName(MetadataActionFolderIcon.java:104)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.AbstractFolder.getIconClassName(AbstractFolder.java:311)
        at PluginClassLoader for branch-api//jenkins.branch.MetadataActionFolderIcon.getIconClassName(MetadataActionFolderIcon.java:104)

@jtnord
Copy link
Member

jtnord commented Dec 12, 2024

@timja and @jtnord I think that this release is causing a stack overflow on my Jenkins controller for both Jenkins 2.479.2 and Jenkins 2.489. Initial configurations that I'm using for my experiments are

I need to do more exploring to narrow the steps to duplicate the issue. Will keep you informed as I learn more.

Stack trace is:

2024-12-12 19:58:39.937+0000 [id=20]    WARNING h.ExpressionFactory2$JexlExpression#evaluate: Caught exception evaluating: it.iconClassName in /. Reason: java.lang.reflect.InvocationTargetException
java.lang.StackOverflowError
        at hudson.ExtensionList.lookup(ExtensionList.java:437)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationUI.for_(RelocationUI.java:113)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationAction.<init>(RelocationAction.java:78)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl.createFor(RelocationAction.java:176)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl.createFor(RelocationAction.java:158)
        at hudson.model.Actionable.createFor(Actionable.java:118)
        at hudson.model.Actionable.getAction(Actionable.java:335)
        at PluginClassLoader for branch-api//jenkins.branch.MetadataActionFolderIcon.getIconClassName(MetadataActionFolderIcon.java:76)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.AbstractFolder.getIconClassName(AbstractFolder.java:311)
        at PluginClassLoader for branch-api//jenkins.branch.MetadataActionFolderIcon.getIconClassName(MetadataActionFolderIcon.java:104)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.AbstractFolder.getIconClassName(AbstractFolder.java:311)
        at PluginClassLoader for branch-api//jenkins.branch.MetadataActionFolderIcon.getIconClassName(MetadataActionFolderIcon.java:104)

Please file a revert pr and merge with your admin permissions if you see fit.
The code at the moment iiuc shouldn't be used by search so there would be not regression in the functionality. This then allows for a less stressful investigation

@MarkEWaite
Copy link
Contributor

Thanks @jtnord . I filed:

I don't have enough permissions to merge the pull request, but will use the incremental until the release is available.

cloudbees-folder:incrementals;org.jenkins-ci.plugins;6.972.v69044ecb_d271

@dwnusbaum
Copy link
Member

@MarkEWaite I approved and merged your PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtnord jtnord jtnord approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timja @janfaracik @MarkEWaite @jtnord @dwnusbaum